Fix restoring window geometry #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coordinates returned by GetWindowPlacement() must be passed to SetWindowPlacement() and not SetWindowPos() as the former functions account correctly for non-standard DPI, while the latter one does not. Using SetWindowPlacement() also allows to remove the checks for the coordinates being valid because the function already checks for this and will always position the window inside the visible area anyhow. Fixes CobaltFusion#370.
If the window was closed in the maximized (or, more rarely, but still possible, minimized) state, restore it in the same state during the next run. Take care to use the appropriate show command for the ShowWindow() call done in Main(), as using SW_SHOWMAXIMIZED with SetWindowPlacement() doesn't work quite as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem of #370 and also restoring the window when it was closed in maximized state.